QTodoTxt2 icon indicating copy to clipboard operation
QTodoTxt2 copied to clipboard

find solution for theming

Open oroulet opened this issue 7 years ago • 12 comments

Currently we have a quite harcoded solution. Ideally it should be qml only but things like icons are part of models in qt so I am not sure how to solve that

oroulet avatar Apr 09 '17 16:04 oroulet

Generally QtQuick Controls 1 (Buttons, Menus, etc...) should be decorated by default suitable to the Desktop Environment. But the colors of the currently used theme can also be accessed in qml (e.g. for styling custom items): http://doc.qt.io/qt-5/qml-qtquick-systempalette.html

At least in KDE if you choose the right "icon-name" in Actions, the according icon appears in Menus and Toolbars (icons can be browsed with cuttlefish (part of kde-sdk)). In Windows this doesnt work for me. I guess we have to deploy some kind of default icon-theme with the app.

fuchsmich avatar Apr 13 '17 12:04 fuchsmich

I agree that we should use system theming as much as possible. I use gnome3. And I have absoluetely no idea how to force a QT theme since they removed the qtconfig app in qt5....

oroulet avatar Apr 13 '17 15:04 oroulet

Could you show me a screenshot, what the app looks like in gnome?

Am 13.04.2017 um 17:15 schrieb oroulet:

I agree that we should use system theming as much as possible. I use gnome3. And I have absoluetely no idea how to force a QT theme since they removed the qtconfig app in qt5....

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/QTodoTxt/QTodoTxt2/issues/2#issuecomment-293925377, or mute the thread https://github.com/notifications/unsubscribe-auth/ACw_Me2h3KOOp59P_P4qcXGet-V_Juegks5rvjwkgaJpZM4M4E64.

fuchsmich avatar Apr 13 '17 16:04 fuchsmich

image

The big empty space appearde when you made the new sorting buttons not visible...

oroulet avatar Apr 13 '17 16:04 oroulet

Its funny how your system behaves differently to my windows and linux system. There is no empty space here.

On Donnerstag, 13. April 2017 18:50:52 CEST oroulet wrote:

![image](https://cloud.githubusercontent.com/assets/2564046/25014922/07eab55 2-207a-11e7-9b18-d685a3f8af96.png)

The big empty space appearde when you made the new sorting buttons not visible...

fuchsmich avatar Apr 13 '17 20:04 fuchsmich

looks like css stylesheets are not supported in QML so we cannot reuse the sheets had...

oroulet avatar Apr 14 '17 08:04 oroulet

Does this help? http://doc.qt.io/qt-5/qtquick-controls-styles-qmlmodule.html

It looks like the syntax is quite similar. I will test it later.

Am 14.04.2017 um 10:59 schrieb oroulet:

looks like css stylesheets are not supported in QML so we cannot reuse the sheets had...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/QTodoTxt/QTodoTxt2/issues/2#issuecomment-294120111, or mute the thread https://github.com/notifications/unsubscribe-auth/ACw_MVuY_zIyN69OZATsrYuTQYcrPXDQks5rvzVigaJpZM4M4E64.

fuchsmich avatar Apr 14 '17 09:04 fuchsmich

for information if we use QApplication from QtGui and not QWidgets then we miss looking at standard systems icons (But this is probably a linux only functionality I guess)

oroulet avatar Apr 18 '17 07:04 oroulet

I already made similar comment under #53, but I just wanted to re-state it here. I agree strongly with @oroulet comment of:

I agree that we should use system theming as much as possible.

FWIW, I am on KDE Plasma with Breeze Dark theme and everything looks very good to me. I know you guys are on different environments, so perhaps I can help the project by reporting what I am seeing in my environment. I don't know enough about coding (yet) but I do want to contribute what I can because I love the project and it meets my needs just about perfectly. :)

TRSx80 avatar Jun 23 '17 13:06 TRSx80

If you want to learn coding, this is a good project. The code is simple with good separation of concern

On Fri, Jun 23, 2017, 15:27 TRSx80 [email protected] wrote:

I already made similar comment under #53 https://github.com/QTodoTxt/QTodoTxt2/issues/53, but I just wanted to re-state it here. I agree strongly with @oroulet https://github.com/oroulet comment of:

I agree that we should use system theming as much as possible.

FWIW, I am on KDE Plasma with Breeze Dark theme and everything looks very good to me. I know you guys are on different environments, so perhaps I can help the project by reporting what I am seeing in my environment. I don't know enough about coding (yet) but I do want to contribute what I can because I love the project and it meets my needs just about perfectly. :)

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/QTodoTxt/QTodoTxt2/issues/2#issuecomment-310665066, or mute the thread https://github.com/notifications/unsubscribe-auth/ACcfzue7NgoBt2CITUXtGHjN3LMRGw_kks5sG71agaJpZM4M4E64 .

oroulet avatar Jun 23 '17 14:06 oroulet

I am using gnome 3 (3.26) with the dark theme and qtodotxt2 did not adopt the dark colours.

severoraz avatar Nov 11 '17 10:11 severoraz

@severoraz I have the same issue. It look like qt5 applcations do not get theme from gnome... While the doc says they should... something does not work.... And it looks like qt5 has no tool to set a theme by hand... any help is welcome on that...

oroulet avatar Nov 11 '17 10:11 oroulet