WaveFox icon indicating copy to clipboard operation
WaveFox copied to clipboard

Icon Overlapping Extension Setting Menu Text on FF 139.0

Open dvbthien opened this issue 7 months ago • 7 comments

Important clarification

  • [x] I have read and followed the installation instructions in the README

Describe the issue

When accessing the extension settings menu, the icon is overlapping the text, which affects readability and overall user experience. See the image below for a detailed view of the error:

Image

To reproduce

  1. Open the extension settings menu within the application.
  2. Observe the layout where the icon and setting text are displayed.
  3. Notice that the icon overlaps part of the menu text.

Expected behavior

The icon should be properly aligned with sufficient spacing from the text, ensuring that all menu items are clearly legible

Additional information

No response

Operating system

MacOS

Color scheme

  • [x] System
  • [x] Light
  • [x] Dark
  • [ ] Contrast

Firefox version

Release

Firefox theme

  • [x] System / Auto
  • [ ] Light
  • [ ] Dark
  • [ ] Repository / AMO

WaveFox version

Release

dvbthien avatar May 27 '25 16:05 dvbthien

Temporary solution. Should work. Add as third-party code.

[needsgutter] { --menu-background-padding-default: var(--context-menu-background-padding) !important; }

QNetITQ avatar May 30 '25 12:05 QNetITQ

Thanks, I tried but it doesn't work

dvbthien avatar May 30 '25 17:05 dvbthien

Then we'll have to wait. I don't support these icons, but I take them from another style. Until the author updates these icons in the original style, everything will remain as it is now. Or until the community finds a solution, if the author doesn't want to solve it.

QNetITQ avatar May 31 '25 06:05 QNetITQ

I am leaning towards the idea of ​​abandoning the current icons and replacing them with others. The current implementation already has problems, and with the release of Firefox 140, there will be even more problems. I don't know yet whether the new icons will replace the current ones or will be an additional option.

QNetITQ avatar Jun 03 '25 17:06 QNetITQ

Added an additional version of icons.

QNetITQ avatar Jun 04 '25 10:06 QNetITQ

Thank you your effort. I appreciate your suggestion about moving away from the current icons. I also think we should add a warning for users know. Do you need me to close this issue?

dvbthien avatar Jun 06 '25 13:06 dvbthien

The new icons are not really suitable as a replacement for the current ones. They are not present in all context menus. It is just an alternative with better support. I will close the issue myself when I release a new version of the style.

QNetITQ avatar Jun 06 '25 13:06 QNetITQ

Released an update. Now there should be no problems with icons.

QNetITQ avatar Jul 05 '25 14:07 QNetITQ

I made a mistake in the updated release. Because of it, most of the icons do not work. I will update the release within 24 hours.

QNetITQ avatar Jul 06 '25 18:07 QNetITQ

Now everything should be fine with the icons. If you encounter any problems again, let me know.

QNetITQ avatar Jul 12 '25 10:07 QNetITQ