python-qinfer icon indicating copy to clipboard operation
python-qinfer copied to clipboard

Correct small negative eigenvalues in covariance

Open mikedeltalima opened this issue 5 years ago • 2 comments

https://github.com/QInfer/python-qinfer/issues/151

Doesn't fail existing tests, but should add a test for this. Could revert some of the auto-whitespace removal if desired.

Deprecated version of the method in utils.py. Should update this as well?

mikedeltalima avatar Nov 22 '19 18:11 mikedeltalima

Coverage Status

Coverage decreased (-0.04%) to 75.592% when pulling 9363f608a14fe596b98b5dd8e26d62811871ba0c on mikedeltalima:covariance-warn into 8170c84a0be1723f8c6b09e0d3c7a40a886f1fe3 on QInfer:master.

coveralls avatar Nov 22 '19 18:11 coveralls

This fixes a warning in an existing test, so I am not going to add a new test unless one is suggested.

src/qinfer/tests/test_smc.py::TestSMCEffectiveSampleSize::test_resample_thresh
  /Users/mdlauria/gitSource/python-qinfer/src/qinfer/distributions.py:397: ApproximationWarning: Numerical error in covariance estimation causing positive semidefinite violation.
    warnings.warn('Numerical error in covariance estimation causing positive semidefinite violation.', ApproximationWarning)

mikedeltalima avatar Dec 13 '19 21:12 mikedeltalima