dcmqi
dcmqi copied to clipboard
QIICR
Initialize private coding scheme identification
See how it is done in https://github.com/QIICR/Iowa2DICOM/blob/master/SingleTimepoint/EncodeMeasurementsSR.cxx#L997
Need to add corresponding components to JSON ...
@pieper this is to follow up on what we discussed about providing more information about private coding scheme used.
It seems you can put somewhat arbitrary strings in those slots, but we may want to encourage a convention that will facilitate finding out the intent of the private coding (e.g. a url to the documentation).
On Fri, Sep 16, 2016 at 4:36 PM, Andrey Fedorov [email protected] wrote:
@pieper https://github.com/pieper this is to follow up on what we discussed about providing more information about private coding scheme used.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/QIICR/dcmqi/issues/90#issuecomment-247703042, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHsfS7lRpY5IXpuf0j12KxpPgL5d5MAks5qqv3OgaJpZM4J_UoU .
@fedorov I know that the referenced source code of "SingleTimepoint/EncodeMeasurementsSR.cxx" has not been updated for a while but just in case it would be revised you might want to use a single call to DSRCodingSchemeIdentificationList::addItem(), i.e. with all 3 (or 4) parameters.
@pieper problem is none of the attributes that can be specified to define a coding scheme is of type UR. I emailed @dclunie asking what he thinks about the possibility of adding specific attribute with the coding scheme URL (for the distant future).
Re. adding specific attribute with the coding scheme URL, see CP 1603 [http://www.dclunie.com/dicom-status/status.html#CP1603].
This issue will be revisited after 1.0.0 as we will be rethinking how schemas are organized and how metadata is communicated to the converters.
It has been our practice to discourage the use of private coding schemes, and over the years of usage, there have been very rarely a need for those. Assigning low priority.