QuantitativeReporting icon indicating copy to clipboard operation
QuantitativeReporting copied to clipboard

ENH: add bidimensional measurement support

Open pieper opened this issue 2 years ago • 6 comments

Before, only single length types were supported (SRT G-D7FE).

This commit adds support for measurements with a long axis (SRT G-A185) and a short axis (SRG G-A186) by creating one markup line node for each axis of each measurement.

This support was added for the LNQ project, where we have ~8,700 annotated lymph nodes in ~3,200 series in SR format.

pieper avatar Jan 02 '23 21:01 pieper

Here's an example of an SR with two bidimensional measurements. We could consider making a custom markup class for this type of measurement, but for now it's two lines. Also the name of the markup is the PersonName of the annotator, which is unknown in this data. Might be better to name based on the FindingSite and differentiate the long and short axes (or only apply the name to one of them).

image

pieper avatar Jan 02 '23 21:01 pieper

Steve, thank you for the contribution. Can you share a sample? Did you validate it?

fedorov avatar Jan 03 '23 04:01 fedorov

No, I don't have a sample I can share.

I'm not sure what you mean by validate. LIke dciodvfy?

pieper avatar Jan 03 '23 14:01 pieper

Can you make a sample on a public dataset?

For validation of TID 1500 SRs, there is a specialized tool DicomSRValidator in PixelMed Toolkit (there is a note about it here: https://qiicr.gitbook.io/dcmqi-guide/opening/cmd_tools/sr/tid1500writer).

fedorov avatar Jan 03 '23 16:01 fedorov

I can't share one of my current examples, but I've tested several and they work with this PR.

Regarding validation, I tried adding index.html as @dclunie suggested, but I don't see the validator DicomSRValidator.sh described in the dcmqi guide.

https://www.dclunie.com/pixelmed/software/index.html

Is there another place to look?

pieper avatar Jan 03 '23 20:01 pieper

Steve, it is in this package pixelmedjavadicom_binaryrelease.20221004.tar.bz2, which is available under this folder https://www.dclunie.com/pixelmed/software/20221004_current/index.html.

fedorov avatar Jan 03 '23 20:01 fedorov