QuantitativeReporting icon indicating copy to clipboard operation
QuantitativeReporting copied to clipboard

Allow modification via unlocking measurement report when set to readonly

Open che85 opened this issue 8 years ago • 8 comments

Users should be allowed to unlock a readonly measurement report. Of the following things need to be taken care:

  • [x] don't touch the original measurement report or segmentation
    • [x] create a copy of the table node
    • [x] create a copy of the segmentation node and reference the copy in the new table node
  • [x] user can always go back an force via selecting original/copy in measurement selector

che85 avatar Jan 10 '17 21:01 che85

@fedorov Did I forget something? Feel free to add bullet points

che85 avatar Jan 10 '17 21:01 che85

We might need to handle it differently based on the completion status, where continuing a just "saved" report can be continued and a "completed" cannot.

che85 avatar Jan 10 '17 21:01 che85

I am not sure it makes sense to create a copy of the measurements table, since we may not be able to recompute the original measurements. I think to me it would be more intuitive if on report modification the table is reset, user is allowed to modify segmentation, which would then be saved into a new DICOM object, and measurements table is recomputed.

fedorov avatar Jan 11 '17 02:01 fedorov

@fedorov Shall we close this issue or do we want to provide this functionality?

che85 avatar Apr 25 '17 16:04 che85

I think it would be good to provide this functionality, but it is not a high priority.

fedorov avatar Apr 25 '17 16:04 fedorov

@fedorov I don't know if this feature is required. It was implemented in https://github.com/che85/Reporting/commit/d88717f85e29c65ef5075a56229251f1315cdc46 but never merged into master

che85 avatar Jan 03 '18 20:01 che85

Yes, I am not sure there was a PR. Let's not worry about it for now - let's resolve bugs and features that are needed for @chribaue use cases, and switch to PI-RADS.

fedorov avatar Jan 03 '18 20:01 fedorov

Ok great. I just wanted to go through all issues and close those ones that have been resolved.

che85 avatar Jan 03 '18 20:01 che85