QCodes Driver SPECS Zurich

[Diddleydope]

[jenshnielsen]

@Diddleydope Thanks for the contribution.

There are a few failures in the Automatic CI build.

When we are building the docs we must be able to import the code. Since your code depends on a module that not explicitly installed you should add it here https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/main/docs/conf.py#L127 to tell Sphinx to mock the missing import.

The type checking using mypy fails for a similar reason.

src/qcodes_contrib_drivers/drivers/SPECS/Specs_Tramea.py:4:1: error: Cannot find implementation or library stub for module named "nanonis_tramea_specs" [import-not-found] src/qcodes_contrib_drivers/drivers/SPECS/Specs_Tramea.py:4:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports src/qcodes_contrib_drivers/drivers/SPECS/Specs_Tramea.py:910:54: error: Invalid type comment or annotation [valid-type] src/qcodes_contrib_drivers/drivers/SPECS/Specs_Tramea.py:910:54: note: Suggestion: use np.array[...] instead of np.array(...) src/qcodes_contrib_drivers/drivers/SPECS/Specs_Tramea.py:920:77: error: Invalid type comment or annotation [valid-type] src/qcodes_contrib_drivers/drivers/SPECS/Specs_Tramea.py:920:77: note: Suggestion: use np.array[...] instead of np.array(...) src/qcodes_contrib_drivers/drivers/Horiba/Horiba_FHR.py:38:9: note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]

You should tell mypy to ignore it here https://github.com/QCoDeS/Qcodes_contrib_drivers/blob/main/pyproject.toml#L76

See comment inline for the numpy issue

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 10.91%. Comparing base (608a88d) to head (3be6e92). Report is 8 commits behind head on main.

Files	Patch %	Lines
...odes_contrib_drivers/drivers/SPECS/Specs_Tramea.py	0.00%	90 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #327      +/-   ##
==========================================
- Coverage   10.97%   10.91%   -0.06%     
==========================================
  Files         132      133       +1     
  Lines       17540    17630      +90     
==========================================
  Hits         1925     1925              
- Misses      15615    15705      +90     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.