Qcodes_contrib_drivers icon indicating copy to clipboard operation
Qcodes_contrib_drivers copied to clipboard

Add SC5511B driver

Open ttshaw1 opened this issue 2 years ago • 3 comments

Added driver for SignalCore SC5511B. Plenty of room for optimizations and new features but might be enough to get some other group up and running.

ttshaw1 avatar Jul 18 '22 23:07 ttshaw1

Codecov Report

Merging #141 (1da9d6a) into master (130370d) will decrease coverage by 1.56%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   18.90%   17.34%   -1.57%     
==========================================
  Files         124      125       +1     
  Lines       14935    16112    +1177     
==========================================
- Hits         2823     2794      -29     
- Misses      12112    13318    +1206     
Impacted Files Coverage Δ
...b_drivers/drivers/SignalCore/SignalCore_sc5511b.py 0.00% <ø> (ø)
...b_drivers/tests/QDevil/test_real_qdac2_ieee_std.py 33.33% <0.00%> (-9.53%) :arrow_down:
...ontrib_drivers/tests/QDevil/real_qdac2_fixtures.py 30.90% <0.00%> (-3.58%) :arrow_down:
...contrib_drivers/tests/QDevil/sim_qdac2_fixtures.py 78.78% <0.00%> (-1.22%) :arrow_down:
...trib_drivers/drivers/ZurichInstruments/ZIHDAWG8.py 55.33% <0.00%> (-0.88%) :arrow_down:
...odes_contrib_drivers/tests/test_Keysight_M3201A.py 15.22% <0.00%> (-0.76%) :arrow_down:
...ivers/drivers/Keysight/SD_common/memory_manager.py 79.64% <0.00%> (-0.36%) :arrow_down:
...contrib_drivers/drivers/ERAInstruments/erasynth.py 0.00% <0.00%> (ø)
...contrib_drivers/tests/test_rohdeschwarz_HMC804x.py 100.00% <0.00%> (ø)
...ontrib_drivers/drivers/Keysight/Keysight_E8267D.py 0.00% <0.00%> (ø)
... and 7 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

codecov-commenter avatar Jul 19 '22 08:07 codecov-commenter

@ttshaw1 could you have a look at these typing errors https://github.com/QCoDeS/Qcodes_contrib_drivers/runs/7405036031?check_suite_focus=true ? if haven't worked with python typing and mypy before, we can do one of the following: exclude this driver from type checking alltogether, add # type: ignore to all the troubling lines, remove existing partial type annotations. I don't recommend either of these, but we have to be realistic and do what we can.

astafan8 avatar Jul 19 '22 08:07 astafan8

@ttshaw1 is there still interest in this driver? It would need a bit of work to get the CI to pass

jenshnielsen avatar Aug 09 '24 13:08 jenshnielsen