QCHackers
Implement remaining spatial hadamard code paths in the fixed boundary convention
This will close issue #631 (and also issue #384, I believe - I have not checked the temporal hadamard implementations, as far as I know they do not have issues and so the only remaining work for this issue was the spatial hadamards).
I've made this a draft PR because it definitely isn't ready to be merged yet. I know I have some issues I need to check about whether I've got the right basis (spatial boundary vs top left,...) and whether the resets and measurements are correct in the hadamard versions, for a start. I also haven't done any testing yet - I am planning to follow @inmzhang's suggestions in issue #384.
I wanted to make a draft PR to get initial feedback on the rough shape of the code - does it look ok, before I start polishing it?
Hi Bella, thanks for the draft PR! I will take time to look into this PR in the next few days.
Hi Bella, thanks for the draft PR! I will take time to look into this PR in the next few days.
Thank you!
Hi Bella, the code structure looks good to me. Would you like me to review the implementation details, such as the template and plaquette definitions, at the current stage of this PR? The logic is kind of complex, and I’m not fully confident that I can check every detail thoroughly. It would be helpful if you could share those details in a some visual format (even a simple hand-drawn draft would do), as that would make it easier for me to review :-)
Thank you very much for looking at it! That's all the feedback I wanted at this stage. Let me make all the small changes I know are wrong, and run the test you suggested in #384, and then it will be ready for a detailed review (at that point I will also write and draw something to make it easier to follow - it took me ages to get my head round it).