sparse-ho icon indicating copy to clipboard operation
sparse-ho copied to clipboard

Comments on Weighted Lasso example with held-out test set

Open ksehic opened this issue 4 years ago • 3 comments

Hi @QB3 @mathurinm

About the weighted Lasso example, it seems you are using kfold for training sparse-ho crossval function, then why are you passing indices in heldout function line 80? It should be HeldOutMSE(None, None)?

It would be nice when you are splitting to have X_train y_test instead of passing again X and y. I have noticed that the number of training samples could be too small. As you can see if we have more samples, sparse-ho is doing better....

image

image

ksehic avatar Feb 05 '21 10:02 ksehic

It should be HeldOutMSE(None, None)?

Yes you are right! thx!

QB3 avatar Feb 08 '21 20:02 QB3

Btw I think I should replace 'WeightedLasso val' by 'WeightedLassoCV' wdyt?

QB3 avatar Feb 08 '21 20:02 QB3

and put LassoCV test, too ?

mathurinm avatar Feb 09 '21 08:02 mathurinm