sparse-ho naming: criterion.py could be criterions.py

naming: criterion.py could be criterions.py

Open mathurinm opened this issue 4 years ago • 3 comments

models.py is already plural, which makes more sense for me

wdyt @QB3 @Klopfe ?

Dec 17 '20 09:12 mathurinm

You mean criteria.py right? ;)

Dec 17 '20 09:12 svaiter

ah... that's bad because correctness would make the access harder to me

Dec 17 '20 09:12 mathurinm

any choice of plural or not is fine for me. Let's jut be consistent

Dec 17 '20 10:12 agramfort