TwitchIO icon indicating copy to clipboard operation
TwitchIO copied to clipboard

Added fetch_channel_emotes & fetch_global_emotes methods

Open ZebcoWeb opened this issue 2 years ago • 2 comments

Pull request summary

Adding Channel and Global emotes API to fetch emotes.

  • Added ChannelEmote and GlobalEmote model class
  • Added get_channel_emotes & get_global_emotes to TwitchHTTP
  • Added fetch_channel_emotes & fetch_global_emotes to Client

Checklist

  • [x] If code changes were made then they have been tested.
    • [ ] I have updated the documentation to reflect the changes.
    • [ ] I have updated the changelog with a quick recap of my changes.
  • [ ] This PR fixes an issue.
  • [x] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • [ ] This PR is not a code change (e.g. documentation, README, ...)

ZebcoWeb avatar Sep 07 '22 15:09 ZebcoWeb

also please run black on your changes, as your pr currently fails the lint test

IAmTomahawkx avatar Sep 21 '22 21:09 IAmTomahawkx

It's also been pointed out to me that these new models haven't been added to the models.rst documentation

IAmTomahawkx avatar Sep 21 '22 22:09 IAmTomahawkx

I'll try to fix these

ZebcoWeb avatar Sep 22 '22 07:09 ZebcoWeb

It's also been pointed out to me that these new models haven't been added to the models.rst documentation

How can I add these models to models.rst?

ZebcoWeb avatar Sep 27 '22 23:09 ZebcoWeb

It's also been pointed out to me that these new models haven't been added to the models.rst documentation

How can I add these models to models.rst?

docs/reference.rst Please also make sure you have updated the changelog

chillymosh avatar Sep 29 '22 15:09 chillymosh

Hello, all we're missing here is the one mentioned issue with the query parameter in http.py Other than that this is ready to go 👍

IAmTomahawkx avatar Oct 04 '22 06:10 IAmTomahawkx

I've gone ahead and made the fixes 👍 Thanks for the PR!

IAmTomahawkx avatar Oct 04 '22 06:10 IAmTomahawkx

I've gone ahead and made the fixes 👍 Thanks for the PR!

Good job!

ZebcoWeb avatar Oct 04 '22 09:10 ZebcoWeb