calendar icon indicating copy to clipboard operation
calendar copied to clipboard

Feature/keyboard shortcuts

Open YairEn opened this issue 5 years ago • 3 comments

Keyboards shortcuts - New Feature:

  • New page of shortcuts explanation can be found by pressing on keyboard shortcuts button in profile page
  • The shortcuts that was added for now are navigation shortcuts to navigate between pages
  • I'm using the Mousetrap.js lib to catch the key press

YairEn avatar Jan 30 '21 18:01 YairEn

Codecov Report

Merging #160 (c79bc08) into develop (b91708d) will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
- Coverage    95.15%   95.11%   -0.04%     
===========================================
  Files           76       77       +1     
  Lines         3382     3359      -23     
===========================================
- Hits          3218     3195      -23     
  Misses         164      164              
Impacted Files Coverage Δ
app/main.py 92.68% <ø> (ø)
app/routers/keyboard_shortcuts.py 100.00% <100.00%> (ø)
app/routers/salary/config.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b91708d...b0a5938. Read the comment docs.

codecov-io avatar Feb 23 '21 09:02 codecov-io

Yam, I am understand that we are not using cypress? I did the tests but I talked to Lisaf and understand the his cypress ticket did not merged

YairEn avatar Feb 23 '21 10:02 YairEn

I'm waiting for @Lisafiluz to resolve the conflicts there

yammesicka avatar Feb 23 '21 10:02 yammesicka