garmin-connect icon indicating copy to clipboard operation
garmin-connect copied to clipboard

Add optional untyped/type parameters to getActivities method

Open dachia opened this issue 1 year ago • 2 comments

Hi, @Pythe1337N

underlying getActivities API can support multiple filters, besides offset or limit. For example, very useful parameters are startDate and endDate, activityType.

I propose that, if possible and make sense, add an optional hashmap parameter to the getActivities call and insert those into request params.

Thank you for all your time and effort!

P.S. If you would prefer it, I can create PR for this

dachia avatar Nov 22 '23 07:11 dachia

This makes sense to me, can you put up a PR for this @dachia?

@dachia where are you able to find the docs of all the filters that are supported by each endpoint?

gregegan avatar Dec 31 '23 08:12 gregegan

Mark as resolved @Pythe1337N https://github.com/Pythe1337N/garmin-connect/pull/73/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5L183

gregegan avatar Jan 18 '24 06:01 gregegan