Fix some serf behavior bugs

[Pyrdacor]

• [ ] When the castle is blocked by fighting knights, the transporter will go back to the castle and won't ever come back.
• [ ] Approaching serfs at flags should change. Sometimes one path will always win and there might be so much resources, that others have no chance at all.

[JSettler]

Question, regarding the castle transporter bug: If i build some stocks (guarded by some fortresses) and move all resources to them, could that be a viable workaround? I guess this only works on sufficiently large maps where one has enough time to evacuate the castle of all goods.. Would you say that bug can be a game-breaking showstopper in some games or would it be counterbalanced if i attack the AI's castle and it gets the same bug, leveling the playing field?

[Pyrdacor]

I'm not sure if you got me right there. Maybe I explained the bug a bit poorly. If I remember correctly if a knight attacks a castle, the guy who would move resources out of the castle will never show up again. Even when the attack is over. So you can't use resources from the castle ever again. This is a real game logic bug which didn't happen in original game and should not happen in freeserf.net as well.

But I don't know if this bug even exists anymore. It is a bit hard to test. But maybe someone has the time to do so. Would be great.

[JSettler]

Sorry, i explained my workaround poorly. I meant, one could evacuate the castle of goods before it ever gets attacked (while the transporter is still working), that could be a workaround for large maps, right? (If i find the time, i could test if the bug is still there, and if the workaround is viable.)

[Pyrdacor]

I prefer to fix the bug instead of a workaround. The player should not need to do stuff to compensate my faulty implementation. :D Moreover it should behave like in the original game. Would be nice if you can test this. :)