pyomo icon indicating copy to clipboard operation
pyomo copied to clipboard

Parmest update of util convert_params_to_vars.

Open smartin71 opened this issue 1 year ago • 4 comments

Fixes # .

Summary/Motivation:

This is step 1 of a set of internal changes to parmest related to issue: https://github.com/Pyomo/pyomo/issues/3252

Changes proposed in this PR:

  • Revamped util function convert_params_to_vars to avoid the use of parameter names as strings.
  • Now using component IDs both internally to the convert function and in the API.

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

smartin71 avatar Aug 10 '24 21:08 smartin71

Codecov Report

Attention: Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.53%. Comparing base (7f779ab) to head (7ea02db). Report is 158 commits behind head on main.

Files Patch % Lines
pyomo/contrib/parmest/utils/model_utils.py 90.90% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3339    +/-   ##
========================================
  Coverage   88.52%   88.53%            
========================================
  Files         868      868            
  Lines       98436    98771   +335     
========================================
+ Hits        87144    87450   +306     
- Misses      11292    11321    +29     
Flag Coverage Δ
linux 86.05% <93.33%> (+0.01%) :arrow_up:
osx 75.63% <6.66%> (-0.03%) :arrow_down:
other 86.55% <93.33%> (+0.01%) :arrow_up:
win 83.86% <93.33%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 16 '24 15:08 codecov[bot]

@blnicho - Do you think you'll have time to look over this one before the Monday patch?

mrmundt avatar Oct 08 '24 18:10 mrmundt

Does this fix #3375?

shermanjasonaf avatar Oct 18 '24 19:10 shermanjasonaf

@djlaky @smondal13 FYI, this is related to some of our Pyomo.DoE development plans

adowling2 avatar Mar 20 '25 23:03 adowling2