pyomo icon indicating copy to clipboard operation
pyomo copied to clipboard

Add a function for cubic spline interpolation

Open eslickj opened this issue 10 months ago • 5 comments

Summary/Motivation:

This adds an external function for cubic spline interpolation. I couldn't find this functionality in Pyomo, but I may have missed something. This is just a draft. I wanted to see if this is worth finishing. I can finish cleaning this up and adding tests or close it. I need functionality similar to this for pump and fan curves.

Changes proposed in this PR:

  • Add an external function cubic spline interpolation function

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

eslickj avatar Mar 28 '24 22:03 eslickj

We discussed in the weekly dev call and expressed that this PR sounds interesting / useful. If you have time, @eslickj , please feel free to push forward with it.

mrmundt avatar Apr 09 '24 18:04 mrmundt

@mrmundt, Thanks! I think it's all there and functioning properly. I'll write tests as I have time.

eslickj avatar Apr 11 '24 21:04 eslickj

@mrmundt, I added tests.

eslickj avatar May 14 '24 21:05 eslickj

@eslickj - The failing test is indicating that you have a missing __init__.py file. Please add that file in and ideally the tests should start passing!

mrmundt avatar May 21 '24 18:05 mrmundt

@mrmundt, I added the file.

eslickj avatar May 22 '24 12:05 eslickj