pyomo icon indicating copy to clipboard operation
pyomo copied to clipboard

Published 20 hours ago • verified publisher icon Pyomo

MindtPy rewrite TODO list

Open ZedongPeng opened this issue 2 years ago • 4 comments

Summary

This issue summarizes the TODO list left in MindtPy rewrite #2654 .

Description

  • [x] Check and improve the var_list generation in MindtPy. https://github.com/Pyomo/pyomo/pull/2654#discussion_r1042471219
  • [x] Decide whether to remove feasible_no_good_cuts. https://github.com/Pyomo/pyomo/pull/2654#discussion_r1042472733
  • [ ] Hard-coded value of zero_tolerance. https://github.com/Pyomo/pyomo/pull/2654#discussion_r1042541553
  • [ ] Redesign the config check in MindtPy. https://github.com/Pyomo/pyomo/pull/2654#discussion_r1042557125
  • [ ] Use StaleFlagManager. https://github.com/Pyomo/pyomo/pull/2654#discussion_r1046333695
  • [ ] Deal with two-sided inequalities. https://github.com/Pyomo/pyomo/pull/2654#discussion_r1048709199
  • [x] Improve the single-tree implementation, especially the solve_data design. https://github.com/Pyomo/pyomo/pull/2654#discussion_r1048800267
  • [ ] Support for external function calls in NLP subproblems
  • [x] https://github.com/Pyomo/pyomo/pull/2654/files/3d01126274de3e3a5beb48d22464083fe6a8fccd#r1054850485
  • [ ] https://github.com/Pyomo/pyomo/pull/2654/files/3d01126274de3e3a5beb48d22464083fe6a8fccd#r1054854281
  • [ ] https://github.com/Pyomo/pyomo/pull/2654#discussion_r1099293796
  • [ ] https://github.com/Pyomo/pyomo/pull/2654#discussion_r1099209447
  • [x] Fix docstring https://github.com/Pyomo/pyomo/pull/2654#discussion_r1106102161
  • [ ] Use standard Pyomo log handler https://github.com/Pyomo/pyomo/pull/2654#discussion_r1106125117
  • [x] Use of setattr https://github.com/Pyomo/pyomo/pull/2654#discussion_r1106139907
  • [ ] Dual sign convention https://github.com/Pyomo/pyomo/pull/2654#discussion_r1106150448
  • [ ] LoadSolutions
  • [ ] warmstart
  • [x] Change default MIP solver from GLPK to something else?

ZedongPeng avatar Jan 30 '23 16:01 ZedongPeng

I will add to this list

  • [ ] Support for external function calls in NLP subproblems

bernalde avatar Jan 30 '23 17:01 bernalde

I'm also adding links to the relevant comments in previous PRs.

  • [ ] https://github.com/Pyomo/pyomo/pull/2654/files/3d01126274de3e3a5beb48d22464083fe6a8fccd#r1054850485
  • [ ] https://github.com/Pyomo/pyomo/pull/2654/files/3d01126274de3e3a5beb48d22464083fe6a8fccd#r1054854281
  • [ ] https://github.com/Pyomo/pyomo/pull/2654#discussion_r1099293796
  • [ ] https://github.com/Pyomo/pyomo/pull/2654#discussion_r1099209447

bernalde avatar Feb 10 '23 19:02 bernalde

Comments from @jsiirola's review

  • [ ] Fix docstring https://github.com/Pyomo/pyomo/pull/2654#discussion_r1106102161
  • [ ] Use standard Pyomo log handler https://github.com/Pyomo/pyomo/pull/2654#discussion_r1106125117
  • [ ] Use of setattr https://github.com/Pyomo/pyomo/pull/2654#discussion_r1106139907
  • [ ] Dual sign convention https://github.com/Pyomo/pyomo/pull/2654#discussion_r1106150448

blnicho avatar Feb 14 '23 23:02 blnicho

It should also deal with options:

  • [ ] LoadSolutions
  • [ ] warmstart
  • [ ] Change default MIP solver from GLPK to something else?

bernalde avatar Feb 20 '23 15:02 bernalde