pyomo icon indicating copy to clipboard operation
pyomo copied to clipboard

[WIP] Adding Pyomo.DOE logo files

Open adowling2 opened this issue 2 years ago • 4 comments

Fixes (none)

Please do not merge until #2294 has been merged.

Summary/Motivation:

  • Pyomo.DOE now has a logo!

Changes proposed in this PR:

  • Adding logo files including .png and .ai similar to other logos

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

adowling2 avatar Sep 07 '22 00:09 adowling2

@jialuw96 the logo is on this branch for future presentations, etc.

adowling2 avatar Sep 07 '22 00:09 adowling2

Not merging! Just approving to streamline merging later.

mrmundt avatar Sep 08 '22 18:09 mrmundt

Converting this to draft/WIP until the Pyomo.DOE PR is merged

blnicho avatar Sep 13 '22 18:09 blnicho

@blnicho @kaklise @jsiirola @mrmundt @jialuw96

We now have two versions of the logo.

Version 1: PyomoDOE-sm

Version 2: PyomoDoE-sm

Files for both are on GitHub (in folders named version 1 and 2 in this draft PR). Once we decide which one to keep, I'll delete the other one. We'll then have the not used version saved in GitHub history.

I like version 2. I agree with @jsiirola that "DOE" may be confused with "Department of Energy". The only downside is that the official paper has "Pyomo.DOE" in the title. IMO, that is not enough to warrant sticking with version 1. Happy to hear comments from others.

adowling2 avatar Sep 18 '22 14:09 adowling2

I just finished editing a presentation and I prefer version 2 (Pyomo.DoE). @jialuw96 any thoughts on referring to our package as Pyomo.DoE?

adowling2 avatar Oct 03 '22 23:10 adowling2

I just finished editing a presentation and I prefer version 2 (Pyomo.DoE). @jialuw96 any thoughts on referring to our package as Pyomo.DoE?

I am okay with this change.

jialuw96 avatar Oct 04 '22 18:10 jialuw96

@adowling2 @jialuw96 I think the consensus was to go with version 2 of the logo, "Pyomo.DoE". Can you remove version 1 from this PR? Once that's done this will be ready to merge.

blnicho avatar Jan 30 '23 20:01 blnicho

Yes, I'll have this ready in 10 minutes.

adowling2 avatar Jan 30 '23 20:01 adowling2

Now let's see if this breaks the documentation.

adowling2 avatar Jan 30 '23 20:01 adowling2

@adowling2 looks like the logo was not included in the readthedocs documentation in #2294 so there is nothing to break. Do you plan to add it as part of this PR or add it as another task under #2610?

blnicho avatar Jan 30 '23 20:01 blnicho

I say merge this and then a separate PR.

adowling2 avatar Jan 30 '23 20:01 adowling2

Codecov Report

Base: 84.97% // Head: 86.79% // Increases project coverage by +1.82% :tada:

Coverage data is based on head (82bb3f5) compared to base (449180c). Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2527      +/-   ##
==========================================
+ Coverage   84.97%   86.79%   +1.82%     
==========================================
  Files         766      766              
  Lines       86041    86041              
==========================================
+ Hits        73113    74679    +1566     
+ Misses      12928    11362    -1566     
Flag Coverage Δ
linux 84.25% <ø> (+1.70%) :arrow_up:
osx 73.66% <ø> (?)
other 84.44% <ø> (+1.89%) :arrow_up:
win 81.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pyomo/repn/plugins/nl_writer.py 93.25% <0.00%> (+0.08%) :arrow_up:
pyomo/core/expr/visitor.py 93.40% <0.00%> (+0.15%) :arrow_up:
pyomo/contrib/interior_point/interior_point.py 95.03% <0.00%> (+0.26%) :arrow_up:
pyomo/solvers/plugins/solvers/GUROBI.py 88.52% <0.00%> (+0.32%) :arrow_up:
...omo/contrib/pynumero/interfaces/nlp_projections.py 89.22% <0.00%> (+0.43%) :arrow_up:
pyomo/opt/results/container.py 75.45% <0.00%> (+0.60%) :arrow_up:
pyomo/solvers/plugins/solvers/CBCplugin.py 82.50% <0.00%> (+0.73%) :arrow_up:
pyomo/solvers/plugins/solvers/IPOPT.py 94.39% <0.00%> (+0.93%) :arrow_up:
pyomo/contrib/gdpopt/solve_discrete_problem.py 78.82% <0.00%> (+1.17%) :arrow_up:
examples/pyomobook/test_book_examples.py 96.86% <0.00%> (+1.17%) :arrow_up:
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jan 30 '23 23:01 codecov[bot]