trypyramid.com icon indicating copy to clipboard operation
trypyramid.com copied to clipboard

Adaptations to Bootstrap 5 / WebPack 5 / Dart Sass

Open ldaverio opened this issue 3 years ago • 5 comments

This PR offers the following upgrades:

  • Bootstrap 3 -> 5
  • Webpack 4 -> 5
  • Node-sass -> Dart Sass (package sass)

Several obsolete dependencies have been removed:

  • bootsrap-sass (Since version 4, Bootstrap uses Sass instead of Less)
  • hugo-bin (not required to run Hugo)
  • file-loader (replaced with asset modules in Webpack 5)

TO DO:

  • bootstrap-multiselect(used on the Addons page) is not compatible with Bootstrap 5. It should probably be replaced by another component, although a workaround exists.
  • font-awesome 4.6 should probably be replaced by the official package, @fortawesome/fontawesome-free.

ldaverio avatar Feb 19 '22 15:02 ldaverio

@ldaverio I've just spent a bunch of time upgrading to Webpack 5. Would you mind rebasing?

Hugo-bin is used because it means people don't need to have Hugo installed separately and makes it easier for CI. Is it I no longer supported? I upgraded it to the latest version on npm.

As for file-loader, can all uses of it be dropped?

digitalresistor avatar Jan 03 '23 00:01 digitalresistor

@ldaverio I've just spent a bunch of time upgrading to Webpack 5. Would you mind rebasing?

Hello @bertjwregeer, happy New Year! I had done the adaptations on short notice one year ago, because Steve seemed to need them urgently, then he suggested I submit a PR to give them a greater visibility. After that, nothing happened.

I'll try to have a look, but I feel I might as well withdraw the pull request, it might just be simpler :)

ldaverio avatar Jan 03 '23 09:01 ldaverio

I rarely touch frontend stuff these days, and I never could get the darned thing to build, following the instructions in README.md. I recall I went down a rabbit hole of dependency hell, and walked away. I left it to others who had the familiarity, time, and patience for it.

That said, I would still like to see it come to fruition.

stevepiercy avatar Jan 03 '23 09:01 stevepiercy

That said, I would still like to see it come to fruition.

Hi Steve, happy New Year! I'll give it a try, then. These days I do a lot of frontend stuff, especially Next.js (a framework based on React). Gave me lots of satisfaction, lots of hair-pulling too, but finally their last beta seems to solve the problem adequately. My experience of the Node/JS ecosystem is that you can do pretty glitzy things with it, but the software stack is very brittle...

PS : Regarding backend / Pyramid, I've recently integrated python_openapi3 after reading one of your e-mails, it's still very rough over the edges, but I rather like it :)

ldaverio avatar Jan 03 '23 09:01 ldaverio

@ldaverio I will readily admit that I had not seen the original PR get opened, and I was deluged with GitHub notifications, hence the duplication of effort of upgrading to the latest version of web pack.

As @stevepiercy we'd still like to see this come to fruition, if you have the time and necessary skillset, I would be ecstatic to review the PR. As it stands you've got a bunch of backend people that are not nearly as good at the frontend stuff!

digitalresistor avatar Jan 03 '23 17:01 digitalresistor