pyramid icon indicating copy to clipboard operation
pyramid copied to clipboard

Quick Tutorial lacks full test coverage and has incorrect tests

Open stevepiercy opened this issue 9 years ago • 18 comments

Due to a lot of copy-pasta in the Quick Tutorial, many of its tests are incorrect and have less than full coverage.

The tutorial documentation should also be updated to reflect the coverage command below. In the introduction, we promise to cover coverage, but it never happens.

 $VENV/bin/py.test tutorial/tests.py --cov-report term-missing --cov=tutorial -q

stevepiercy avatar Apr 16 '16 20:04 stevepiercy

I plan to work on this issue during the PyCon sprints. Posting this here to notify any other sprinting members to consider this taken.

teekennedy avatar Jun 02 '16 20:06 teekennedy

The GET request should also not have the password sent in the clear across the wire.

digitalresistor avatar Jun 02 '16 20:06 digitalresistor

@cyphus: any progress on this? If someone were to pick this up, you already have some work done somewhere?

zupo avatar Oct 28 '16 11:10 zupo

@zupo I'd say this issue is up for grabs. I've also added a label for DragonSprint.

stevepiercy avatar Nov 17 '16 22:11 stevepiercy

Hey there. I have some partial work done on this issue but I'm glad to hand it over in case anyone wants to work on it. I'll push it up to a fork tonight and link to it here.

teekennedy avatar Nov 17 '16 22:11 teekennedy

I cleaned up what I've done so far and pushed to a branch here: https://github.com/cyphus/pyramid/tree/2504-quick-tutorial-test-coverage

teekennedy avatar Nov 18 '16 07:11 teekennedy

Thanks!

zupo avatar Nov 19 '16 12:11 zupo

I plan to work on this.

livike avatar Dec 06 '16 10:12 livike

Was there any progress on this?

mmerickel avatar Dec 12 '16 02:12 mmerickel

Yes, but still not covered entirely.

livike avatar Dec 12 '16 07:12 livike

I'll be happy if we get this in, but I'm dropping it from the 1.8 milestone so as not to hold up the release.

mmerickel avatar Dec 15 '16 07:12 mmerickel

Is anyone planning to work on this for 1.9 or should I push it off again?

mmerickel avatar May 03 '17 19:05 mmerickel

I will be mostly offline during the summer so cannot focus on this before end of Sept.

zupo avatar May 03 '17 20:05 zupo

Unless it gets picked up at PyCon sprints, then let's push it off again.

stevepiercy avatar May 03 '17 23:05 stevepiercy

I'm probably releasing 1.9 before the sprints. At least that's my current plan.

mmerickel avatar May 04 '17 00:05 mmerickel

Anyone working on this ?

heronrs avatar Mar 15 '18 19:03 heronrs

@heron182 nope. Be our guest!

stevepiercy avatar Mar 15 '18 19:03 stevepiercy

Yet another PyCon and I'm working on it #3284

keitheis avatar May 15 '18 20:05 keitheis