deformdemo icon indicating copy to clipboard operation
deformdemo copied to clipboard

Fix seq widgets

Open krysros opened this issue 2 years ago • 2 comments

This pull request should fix functional tests of https://github.com/Pylons/deform/pull/518.

krysros avatar Jun 12 '22 20:06 krysros

@krysros I started the run, and so far lint failed, but it's not clear to me why. Perhaps you can make sense of it?

https://github.com/Pylons/deformdemo/runs/6872633267?check_suite_focus=true

We'll see about the other builds. At this point, I am OK with dropping Python 3.6 and adding 3.10, too.

stevepiercy avatar Jun 14 '22 02:06 stevepiercy

@stevepiercy

I have no idea about lint fail yet. I passed all functional tests running locally from deform with the changes applied in https://github.com/Pylons/deform/pull/523, https://github.com/Pylons/deform/pull/524, https://github.com/Pylons/deformdemo/pull/123 and with the following modifications of https://github.com/Pylons/deform/blob/1a6e9e07a9a7fa0208c1aa219649d99ebc132eb7/run-selenium-tests.bash#L31

git clone --branch fix-seq-widgets https://github.com/krysros/deformdemo.git deformdemo_functional_tests

krysros avatar Jun 16 '22 17:06 krysros