deform icon indicating copy to clipboard operation
deform copied to clipboard

Form.formid has no effect on Field.oid autogeneration

Open ezag opened this issue 5 years ago • 1 comments

As per docs, formid argument is intended for placing more than one Deform form into a single page. Though autogenerated oids will conflict in this case (violating HTML standard and breaking JS that rely on DOM ids) unless being explicitly specified in schema, or multiple forms being initialized with a shared counter. Could this be fixed by making parent formid a part of autogenerated oid?

ezag avatar Feb 06 '20 15:02 ezag

@ezag I think that is a good proposal. Would you like to submit a PR with tests? I'd accept it.

Please note that we are dropping Python 2.7 and 3.4 in the next release, so you don't need to test for that.

stevepiercy avatar May 12 '20 09:05 stevepiercy