deform icon indicating copy to clipboard operation
deform copied to clipboard

Templates have support for missing features: input_prepend/input_append

Open a3kov opened this issue 8 years ago • 8 comments

There's a mention in TODO:

NEW FEATURES:

  • input_prepend/input_append in mapping_item widget

I would ignore it if it wasn't implemented, but there's some support for it in the mapping_item template, which is very confusing. I suggest to remove it from the template, or to implement fully to avoid confusion. I guess if it was implemented it would appear elsewhere (widget code?) but currently its only in the template.

a3kov avatar Apr 02 '17 09:04 a3kov

Also, in the form template, there's a support for a missing button.icon feature.

a3kov avatar Apr 02 '17 16:04 a3kov

Closed since there is a TODO item on this.

goodwillcoding avatar May 15 '17 06:05 goodwillcoding

I still think its useful to have this issue open so other people could find it easier to understand what's going on. Sorry that I can't commit because I don't know/like chameleon. I encountered it while porting templates to mako

a3kov avatar May 15 '17 08:05 a3kov

Reopened the issue to discuss to have better understanding about the question.

miohtama avatar May 15 '17 08:05 miohtama

I think TODO list have not been maintained for 5 years and I should delete the file. I can guide you to implement a new widget and learn Chameleon if necessary.

miohtama avatar May 15 '17 08:05 miohtama

@miohtama it's confusing for someone who is converting/reimplementing templates, that's all. Templates contain dead code, the code that is not doing anything.

a3kov avatar May 15 '17 08:05 a3kov

#217 contains support for the button icons

tisdall avatar May 15 '17 12:05 tisdall

wtf is input_prepend/input_append intended to do? There is no documentation or discussion about it anywhere in the repo or TODO. Can I get some history from the old-tymers?

stevepiercy avatar Aug 24 '20 12:08 stevepiercy