vue-ripple-directive
vue-ripple-directive copied to clipboard
Ripple never disappears after click and drag
When using the default mousedown event, if the user clicks on the rippled element and (without releasing) drags the cursor outside the element, the ripple just stays there and doesn't disappear like it's supposed to.
Codepen example: https://codepen.io/7oot/pen/OEgmML
After a few clicks & drags, you'd get multiple ripple containers stacked on top of each other and all disappear after a normal click & release.
This also happens when you just right-click
Any plan to fix this issue?
Yep, this is an issue and ideas?
I think I'll give it a go over the weekend
Awesome, with that final touch this directive will be ace
looks like it's been fixed here https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files but it doesn't look like it's gonna get merged :(
@ma7moudat oh, well. Still not merged =(
Was this ripple.js file not reflected in the latest version? https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files
@2ju2 nop, still waiting for merge. Looks like this project is dead. Maybe I'll fork the lib and apply this change for myself.
looks like it's been fixed here https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files but it doesn't look like it's gonna get merged :(
Your changes to the button tag will not work
I solved this problem. Hoping the author will merge my changes into the project.
https://github.com/PygmySlowLoris/vue-ripple-directive/pull/31/files