vue-ripple-directive icon indicating copy to clipboard operation
vue-ripple-directive copied to clipboard

Ripple never disappears after click and drag

Open ma7moudat opened this issue 7 years ago • 11 comments

When using the default mousedown event, if the user clicks on the rippled element and (without releasing) drags the cursor outside the element, the ripple just stays there and doesn't disappear like it's supposed to.

Codepen example: https://codepen.io/7oot/pen/OEgmML

After a few clicks & drags, you'd get multiple ripple containers stacked on top of each other and all disappear after a normal click & release.

ma7moudat avatar Jun 13 '18 11:06 ma7moudat

This also happens when you just right-click

Lavrend avatar Aug 07 '18 22:08 Lavrend

Any plan to fix this issue?

ppsirius avatar Dec 18 '18 15:12 ppsirius

Yep, this is an issue and ideas?

kgrosvenor avatar Jul 10 '19 16:07 kgrosvenor

I think I'll give it a go over the weekend

ma7moudat avatar Jul 12 '19 07:07 ma7moudat

Awesome, with that final touch this directive will be ace

kgrosvenor avatar Jul 12 '19 12:07 kgrosvenor

looks like it's been fixed here https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files but it doesn't look like it's gonna get merged :(

ma7moudat avatar Jul 15 '19 08:07 ma7moudat

@ma7moudat oh, well. Still not merged =(

RedBlueKoi avatar Jan 07 '20 08:01 RedBlueKoi

Was this ripple.js file not reflected in the latest version? https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files

2ju2 avatar Mar 27 '20 03:03 2ju2

@2ju2 nop, still waiting for merge. Looks like this project is dead. Maybe I'll fork the lib and apply this change for myself.

RedBlueKoi avatar Mar 27 '20 08:03 RedBlueKoi

looks like it's been fixed here https://github.com/PygmySlowLoris/vue-ripple-directive/pull/19/files but it doesn't look like it's gonna get merged :(

Your changes to the button tag will not work

amirhossein-fzl avatar Nov 08 '20 16:11 amirhossein-fzl

I solved this problem. Hoping the author will merge my changes into the project.

https://github.com/PygmySlowLoris/vue-ripple-directive/pull/31/files

amirhossein-fzl avatar Nov 18 '20 08:11 amirhossein-fzl