pylightxl icon indicating copy to clipboard operation
pylightxl copied to clipboard

(feature request) please consider adding type defintions

Open ZeeD opened this issue 2 years ago • 1 comments

Pylightxl Version: 1.59 Python Version: 3.9

Summary of Bug/Feature: at the moment pylightxl doesn't use types, nor it expose them. So tools like mypy cannot check the user interactions

Traceback:

Suggestion for fix:add typing annotations to the module

ZeeD avatar Jun 02 '22 13:06 ZeeD

@ZeeD Thank you for considering using pylightxl for your project. This should be an easy add, we'll just have to make sure it is py2 backwards compatible looks like here is what we will need to follow

PydPiper avatar Jun 14 '22 00:06 PydPiper

Thank you for doing this work. I am using Pylance (seems to be the default for Visual Studio Code) and it highlights a small number of possibly serious type issues. I am looking forward to using the new version.

tpc1095 avatar Oct 24 '22 13:10 tpc1095

added in v1.61

PydPiper avatar Jan 01 '23 22:01 PydPiper