pycord icon indicating copy to clipboard operation
pycord copied to clipboard

fux: GuildSchedule not being cached correctly

Open Lumabots opened this issue 3 months ago • 3 comments

Summary

summary is not complete, just check the code

Added New Enums : ScheduledEventRecurrenceFrequency (yearly, monthly, weekly, daily) ScheduledEventRecurrenceWeekday (monday-sunday) ScheduledEventRecurrenceMonth (january-december)

New Classes: ScheduledEventEntityMetadata (location) ScheduledEventRecurrenceNWeekday Represents n-weekday entries (e.g., "1st Tuesday") ScheduledEventRecurrenceRule: Full recurrence rule with validation

Auto-validates on to_payload() serialization New fields Guild.create_scheduled_event():

  • well at this point just read the code

Enforces Discord's constraints:

  • Frequency-specific field combinations
  • Mutually exclusive field checks
  • Valid weekday set validation for daily events
  • Required field enforcement for yearly events

Information

  • [ ] This PR fixes an issue. #1709
  • [ ] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • [ ] I have searched the open pull requests for duplicates.
  • [ ] If code changes were made then they have been tested.
    • [ ] I have updated the documentation to reflect the changes.
  • [ ] If type: ignore comments were used, a comment is also left explaining why.
  • [ ] I have updated the changelog to include these changes.

Lumabots avatar Dec 09 '25 19:12 Lumabots

Thanks for opening this pull request! Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/3025/head:pr-3025
git checkout pr-3025

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/3025/head

pycord-app[bot] avatar Dec 09 '25 19:12 pycord-app[bot]

Audit Logs still need to be rework (i didnt understand how it work yet)

Lumabots avatar Dec 09 '25 19:12 Lumabots

should we use use_cache_on_error, instead of only use cache ? that way we will be able to fetch first and if unavailable we will get Open of better variable name

Lumabots avatar Dec 10 '25 07:12 Lumabots

If possible, make this pr not interfere with the recurrence one from anonymous. There will probably be merge conflicts once that one is merged, but they shouldn't both implement recurrence in a different way.

when anonymous pr will be merged i'll edit it to make it work

Lumabots avatar Dec 12 '25 06:12 Lumabots

fixed ur fux image

Lulalaby avatar Dec 12 '25 08:12 Lulalaby

That was me :sob: image

Paillat-dev avatar Dec 12 '25 08:12 Paillat-dev