pycord icon indicating copy to clipboard operation
pycord copied to clipboard

fix(voice): Voice internals rewrite to fix things

Open DA-344 opened this issue 6 months ago • 4 comments

Summary

If you don't want your code to explode or something similar, don't use this PR, thanks. ;)

WIP.

A rewrite to its internals to fix various things.

I don't expect this to be merged on 2.7, so it should not block it

This is partially inspired on discord.py's voice code & imayhaveborkedit/voice-recv

Information

  • [x] This PR fixes an issue.
  • [x] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • [x] I have searched the open pull requests for duplicates.
  • [ ] If code changes were made then they have been tested.
    • [ ] I have updated the documentation to reflect the changes.
  • [x] If type: ignore comments were used, a comment is also left explaining why.
  • [ ] I have updated the changelog to include these changes.

Related

Fixes #2833

DA-344 avatar Aug 21 '25 22:08 DA-344

This PR can now be tested, all features (and rewrite) should be done, and I need to fix errors.

There can be some breaking change, if you find one, let me know and i’ll add backwards compatibility.

DA-344 avatar Aug 30 '25 13:08 DA-344

Mhm image

Paillat-dev avatar Aug 30 '25 13:08 Paillat-dev

Yeah that is due to a type annotation i forgot to update but in my local machine it worked lol

DA-344 avatar Aug 30 '25 13:08 DA-344

@DA-344 just that u are aware: https://github.com/Pycord-Development/pycord/pull/2808

Lulalaby avatar Aug 30 '25 15:08 Lulalaby