pycord icon indicating copy to clipboard operation
pycord copied to clipboard

feat: Support default_values for Select of type ComponentType.mentionable_select and ComponentType.channel_select

Open doluk opened this issue 9 months ago • 2 comments

Summary

Looking at https://discord.com/developers/docs/components/reference#user-select I noticed that there is support for preselecting users, channels, roles, mentionables for the non string selects. This pr adds support for this.

Information

  • [ ] This PR fixes an issue.
  • [x] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • [x] I have searched the open pull requests for duplicates.
  • [x] If code changes were made then they have been tested.
    • [x] I have updated the documentation to reflect the changes.
  • [ ] If type: ignore comments were used, a comment is also left explaining why.
  • [x] I have updated the changelog to include these changes.

doluk avatar May 27 '25 16:05 doluk

@NeloBlivion Would this interfere with #2707 ?

Paillat-dev avatar May 29 '25 10:05 Paillat-dev

I addressed most of the review comments, the two left open are something which need a final decision on what to do. @Paillat-dev @JustaSqu1d Hope the example I added is suitable

doluk avatar Jun 06 '25 10:06 doluk

@doluk can you take a look at the merge conflicts ?

Paillat-dev avatar Aug 05 '25 19:08 Paillat-dev

the component v2 merge created that, I am not sure there is an easy way out of it. I was thinking about opening another pr from the current main instead of trying to resolve the conflicts somehow

doluk avatar Aug 05 '25 19:08 doluk

@doluk I am going to try the merge and we'll see..

Paillat-dev avatar Aug 05 '25 19:08 Paillat-dev

@doluk I merged it but I am not sure it is all good, would you mind taking a look ?

Paillat-dev avatar Aug 05 '25 19:08 Paillat-dev

@doluk updates?

plun1331 avatar Aug 23 '25 01:08 plun1331

Would be nice if either

  • it's being worked on by you @doluk
  • or taken over by one of the contributors / core team

Another upcoming feature (in a few~ish weeks) depends on that as well

Lulalaby avatar Aug 23 '25 01:08 Lulalaby

Let's do a clean new pr

Lulalaby avatar Sep 01 '25 15:09 Lulalaby