pycord icon indicating copy to clipboard operation
pycord copied to clipboard

fix(colour): Fix dark_theme color

Open bastigamedc opened this issue 10 months ago • 8 comments

Summary

In this PR I set the color of dark_theme to the new dark_theme color of Discord

Information

  • [x] This PR fixes an issue.
  • [ ] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • [x] I have searched the open pull requests for duplicates.
  • [x] If code changes were made then they have been tested.
  • [x] I have updated the documentation to reflect the changes.
  • [x] If type: ignore comments were used, a comment is also left explaining why.
  • [ ] I have updated the changelog to include these changes. (I don't know where to update this)

bastigamedc avatar Apr 26 '25 07:04 bastigamedc

Do we even need that anymore. There's too many "dark themes" now. Even without nitro. /gen Q for @Pycord-Development/contributors

Lulalaby avatar Apr 26 '25 07:04 Lulalaby

Or should I add an individual function for each theme?

bastigamedc avatar Apr 26 '25 08:04 bastigamedc

This color is completely irrelevant now anyways with components v2

plun1331 avatar Apr 26 '25 09:04 plun1331

if we were to go ahead with this PR, then we should have the previous dark color in a field called old_dark_theme or something

JustaSqu1d avatar Apr 28 '25 03:04 JustaSqu1d

i think "dark_theme" should be left as is and deprecated in favour of the official names "dark", "onyx" and "ash"

NeloBlivion avatar Apr 28 '25 03:04 NeloBlivion

I think we should get rid of all these "theme" things. I see no use in it anyways

Lulalaby avatar Apr 28 '25 12:04 Lulalaby

The use afaik is for making it blend with the bg

Paillat-dev avatar Apr 28 '25 13:04 Paillat-dev

The use afaik is for making it blend with the bg

There are too many backgrounds for it to be reasonable anymore (also no gradients) The best solution if you really want this functionality would be to use cv2

plun1331 avatar May 09 '25 19:05 plun1331