feat: :sparkles: Add missing feature flags to `Guild.edit`
Summary
https://discord.com/developers/docs/resources/guild#guild-object-guild-features and also https://discord.com/channels/881207955029110855/881224361015672863/1318631076209491968
This also fixes an issue where one could not edit the state of both the COMMUNITY and INVITES_DISABLED flags at once.
Information
- [ ] This PR fixes an issue.
- [x] This PR adds something new (e.g. new method or parameters).
- [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
- [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).
Checklist
- [x] I have searched the open pull requests for duplicates.
- [x] If code changes were made then they have been tested.
- [x] I have updated the documentation to reflect the changes.
- [ ] If
type: ignorecomments were used, a comment is also left explaining why. - [x] I have updated the changelog to include these changes.
I thought we stopped maintaining guild.features.
Oh. I didn't know that. Lala just told me I could do it But I'm interested in knowing why this wouldn't be supported by pycord anymore - it's part of the api after all.
Oh. I didn't know that. Lala just told me I could do it But I'm interested in knowing why this wouldn't be supported by pycord anymore - it's part of the api after all.
We'd be adding a new feature flag like every week. Most feature flags aren't really even used.
This pr focuses on adding toggle in Guild.edit for feature flags that can be edited. It does not add feature flags to the list. Maybe my pr title is misleading ?
-
I've removed the variable and added a comparison between the new list of features and the old one instead. Tested, works.
-
I realised the new parameter for feature
RAID_ALERTS_DISABLEDis calledraid_alertswithout a verb but forINVITES_DISABLEDwe havedisable_invites. Therefore I suggest replacingraid_alertswithdisable_raid_alerts. -
Here, one of
ACTIVITY_FEED_ENABLED_BY_USERandACTIVITY_FEED_DISABLED_BY_USERalways gets added no matter the value ofenable_activity_feed. Could a user not want to remove both? I really don't know whether that's an option. Also this is the only parameter calledenable. Maybe keep but adddisable_activity_feed?
activity feed is an opt-in thing, hence it has an enable flag
- Ok.
- I can take a look and see if I can make it more consistent. - done
- They both toggle the same thing. Idk why there are two flags, probably discord wanted to "enable it" for all guilds without having to add a flag to each and every guild so the default when none of the two flags are present is to be enabled. Honestly idk that's just how it's implemented.