pycord icon indicating copy to clipboard operation
pycord copied to clipboard

feat(ext.pages): Add ButtonTypes presets for paginator buttons

Open Nzii3 opened this issue 2 years ago • 11 comments

Summary

Adds a ButtonTypes class that allows users to use preset paginator button styles easily.

THIS PR IS STILL NOT FINISHED!

Information

  • [ ] This PR fixes an issue.
  • [x] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • [x] I have searched the open pull requests for duplicates.
  • [x] If code changes were made then they have been tested.
    • [ ] I have updated the documentation to reflect the changes.
  • [x] If type: ignore comments were used, a comment is also left explaining why.

Nzii3 avatar Dec 03 '22 21:12 Nzii3

Isn't that a dup of https://github.com/Pycord-Development/pycord/pull/1811 ?

Couldn't that be done in scope of that pr?

Lulalaby avatar Dec 04 '22 00:12 Lulalaby

Isn't that a dup of #1811 ?

Couldn't that be done in scope of that pr?

I think this PR is based on that other PR because this PR requires changes made in the other PR.

EmmmaTech avatar Dec 04 '22 00:12 EmmmaTech

Misread, sorry.

EmmmaTech avatar Dec 04 '22 00:12 EmmmaTech

Isn't that a dup of #1811 ?

Couldn't that be done in scope of that pr?

@Lulalaby I think Bob wanted a separate thing but they are similar. Context

Nzii3 avatar Dec 04 '22 02:12 Nzii3

I could add it into that pr tho

Nzii3 avatar Dec 04 '22 02:12 Nzii3

status?

BobDotCom avatar Jan 05 '23 18:01 BobDotCom

status?

Sorry, not done yet. Been kinda busy with other projects. I’ll work on it this weekend.

Nzii3 avatar Jan 06 '23 05:01 Nzii3

Could you add a way to pass in the ButtonTypes class into a classmethod constructor (or as a param in the init constructor) for the paginator? The use_styled_buttons/use_default_buttons params should also access the ButtonTypes class.

BobDotCom avatar Jan 10 '23 16:01 BobDotCom

Could you add a way to pass in the ButtonTypes class into a classmethod constructor (or as a param in the init constructor) for the paginator? The use_styled_buttons/use_default_buttons params should also access the ButtonTypes class.

Will do.

Nzii3 avatar Jan 10 '23 23:01 Nzii3

status update?

BobDotCom avatar Feb 10 '23 18:02 BobDotCom

Been busy.

Nzii3 avatar Feb 14 '23 01:02 Nzii3

@Nzii3 shall we trash this

Lulalaby avatar Aug 10 '24 11:08 Lulalaby

@Nzii3 shall we trash this

@Lulalaby yes

Nzii3 avatar Aug 11 '24 17:08 Nzii3