pycord
pycord copied to clipboard
Rename `original_message` to `original_response`
Summary
This PR renames original_message
to original_response
.
Information
- [ ] This PR fixes an issue.
- [ ] This PR adds something new (e.g. new method or parameters).
- [x] This PR is a breaking change (e.g. methods or parameters removed/renamed).
- [ ] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).
Checklist
- [x] I have searched the open pull requests for duplicates.
- [x] If code changes were made then they have been tested.
- [x] I have updated the documentation to reflect the changes.
- [x] If
type: ignore
comments were used, a comment is also left explaining why.
This is a big breaking change. edit_original_message
, delete_original_message
, and any other attributes/methods you renamed should be aliases instead.
discord.py
seems to have made this same breaking change, yet has not added any aliases.
discord.py
seems to have made this same breaking change, yet has not added any aliases.
Then why does that mean you shouldn't make aliases in this PR. Remember, this library isn't a part of discord.py
anymore, it's its own thing
discord.py
seems to have made this same breaking change, yet has not added any aliases.
Why does it have to be discord.py
?
This is a big breaking change.
edit_original_message
,delete_original_message
, and any other attributes/methods you renamed should be aliases instead.
Do I have to mention the alias in the docs?
This is a big breaking change.
edit_original_message
,delete_original_message
, and any other attributes/methods you renamed should be aliases instead.Do I have to mention the alias in the docs?
Yes
@EmreTech The requested changes have been made.
@EmreTech The requested changes have been made.
You don't have to tell me BTW. Just request for my review again
Please update the @utils.deprecated
decorators to use the new parameters introduced in #1657.
Why is the workflow failing?
How did you managed to fail all tests. Ian deploy?
@Lulalaby I fixed the errors.
discord.py
seems to have made this same breaking change, yet has not added any aliases.
This was changed before the stable release of discord.py 2.0 thus making it not a breaking change... because you know it's a major version change and this method (or even the whole class) didn't exist before 2.0. Also yes like others have already mentioned, this lib has nothing to do with discord.py so it shouldn't even be brought up.
~~didn't notice that was from 2 months ago~~