pycord icon indicating copy to clipboard operation
pycord copied to clipboard

Categorize Event Reference events

Open pandaninjas opened this issue 3 years ago • 5 comments
trafficstars

Summary

This pull requests resolves #455. This classifies events in the documentation. Let me know if you want anything changed

Information

  • [ ] This PR fixes an issue.
  • [x] This PR adds something new (e.g. new method or parameters).
  • [ ] This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • [x] This PR is not a code change (e.g. documentation, README, typehinting, examples, ...).

Checklist

  • [x] I have searched the open pull requests for duplicates.
  • [ ] If code changes were made then they have been tested.
    • [ ] I have updated the documentation to reflect the changes.
  • [ ] If type: ignore comments were used, a comment is also left explaining why.

pandaninjas avatar Jul 28 '22 03:07 pandaninjas

The diff I'm looking at displays the entire API reference as modified, and as such I can't really see what changes were made.

plun1331 avatar Jul 28 '22 05:07 plun1331

The diff I'm looking at displays the entire API reference as modified, and as such I can't really see what changes were made.

I'm going to see what I can do about that.

pandaninjas avatar Jul 28 '22 15:07 pandaninjas

Fixed in latest commit

pandaninjas avatar Jul 28 '22 15:07 pandaninjas

I feel at the very least these categories should be alphabetically sorted as these sections feel kinda messy. Atop of that, I'm not sure if having an "other" section is a great idea and it'd probably be better to just be more specific in each section's title.

baronkobama avatar Jul 28 '22 15:07 baronkobama

I feel at the very least these categories should be alphabetically sorted as these sections feel kinda messy. Atop of that, I'm not sure if having an "other" section is a great idea and it'd probably be better to just be more specific in each section's title.

For the other section, do you want me to create a section for each event in other?

pandaninjas avatar Jul 28 '22 15:07 pandaninjas

@pandaninjas please resolve conflicts @Pycord-Development/maintainers please review

Lulalaby avatar Sep 22 '22 15:09 Lulalaby

Oops, I accidentally discarded all my commits

pandaninjas avatar Sep 22 '22 16:09 pandaninjas

I can't seem to make GitHub recognize the new commits on this branch, I've opened a new PR #1644

pandaninjas avatar Sep 22 '22 17:09 pandaninjas