PySpice icon indicating copy to clipboard operation
PySpice copied to clipboard

Published 20 hours ago • verified publisher icon PySpice-org

Fix #352

Open cyber-g opened this issue 2 years ago • 1 comments

NGSpice has changed the structure of its output (on 2021-01-01 and 2022-03-14) ; please read https://github.com/PySpice-org/PySpice/issues/352#issuecomment-1712030701 for more info.

There is a mismatch between what is expected in PySpice and the actual output. _read_header() is in charge of processing the output from NGSpice.

This PR implements a fix that addresses the new possible structures of the output of NGSpice. It considers that the output can have three formats which can happen depending on the host linux distribution:

  • NGSpice before 2021-01-01 : nothing before "Circuit:"
  • NGSpice between 2021-01-01 and 2022-03-14 : a message is present before "Circuit:"
  • NGSpice after 2022-03-14 : the message present before "Circuit:" begins with "Note:"

cyber-g avatar Sep 25 '23 08:09 cyber-g

Does anyone know how to fix CodeQL / Analyze (cpp) (pull_request) Failing after ... ? image

cyber-g avatar Sep 25 '23 09:09 cyber-g