PySpice icon indicating copy to clipboard operation
PySpice copied to clipboard

Correction for the method SubCircuit.check_nodes()

Open jmgc opened this issue 6 years ago • 8 comments

I have made some slight changes to correct the check_nodes method in SubCircuit, and convert a SubCircuit node in an object of the class Node so the code can be reused.

Thanks in advance

jmgc avatar Nov 28 '18 13:11 jmgc

Thanks to help to improve PySpice !

Main concern is to find a way to decouple the netlist and the schematic stuff so as to keep PySpice independent of the simulator and the schematic renderer.

Must found some time to work on this and the latest issues ! Will try during Christmas week !

FabriceSalvaire avatar Nov 30 '18 15:11 FabriceSalvaire

I have added improvements on the Parser and the Xyce usage. I have also removed the SchemDraw functionality to allow a simpler merge.

jmgc avatar Apr 25 '20 05:04 jmgc

How your branch was related to SchemDraw #135 ? Somehow I would like to keep the code related to SchemDraw on a PR for later usage.

My concern with so huge change is I need to cherry pick in the diff and to understand each change to avoid mistakes.

Did you found an issue with name -> name ?

FabriceSalvaire avatar May 04 '20 19:05 FabriceSalvaire

I just can tell you that it has been thoroughly tested, and solves different issues in the Parser and other stuff. I will continue working, and adding functionalities as I need them when simulating circuits.

Regarding the name, the issue is related with the caps and also the parser.

Just add that the changes are huge because the time span has also been.

jmgc avatar May 04 '20 20:05 jmgc

Qeustion about SchemDraw : How your branch was related to SchemDraw #135 ?

Just because I don't want to close an PR with unmerged code

FabriceSalvaire avatar May 04 '20 21:05 FabriceSalvaire

I have removed any dependency on SchemDraw.

jmgc avatar May 05 '20 07:05 jmgc

CHERRY PICK / MERGE STATUS

  • [x] custom dunders fixed in 0816db6

TODO

  • to make diff easier : fork this PR to update dunder ?

FabriceSalvaire avatar Jul 14 '20 14:07 FabriceSalvaire

Updated to include the latests changes in the main repository, solving all the conflicts found. Include an expression parser based on tatsu (see EBNFExpressionParser). Solved some issues with the spice parser (see EBNFSpiceParser).

jmgc avatar Mar 06 '23 08:03 jmgc