pypsa-usa
pypsa-usa copied to clipboard
PyPSA
Updates GitHub Action
Changes proposed in this Pull Request
Updates the testing workflow file. I believe no configurations met the imposed filtering options on what os to run on. I have enabled running on main branch Linux.
Should address comment in issue #207. Not tagging it as a linked PR in case other items still need to be addressed with the action
Checklist
- [x] I tested my contribution locally and it seems to work fine.
- [x] Code and workflow changes are sufficiently documented.
- [x] Changed dependencies are added to
envs/environment.yaml. - [x] Changes in configuration options are added in all of
config.default.yaml. - [x] Changes in configuration options are also documented in
doc/configtables/*.csv.
I'm disabling the action until one of us spends time to properly set it up.
@ktehranchi Agreed! Maybe a silly question, but whats the goal of the action? (I do realize I was the author of the original issue ticket, but I can't quite remember haha)
- To check if the snakemake workflow is still functional? In which case we can just use the dry run flag to test all the rules still connect?
- To check if the snakemake workflow will run top to bottom? In which case we are having to create a seperate config file for every option in our config file? If this is the goal, I wonder if it is better to just test each script separately with simple network fixtures?
- To check if the workflow will make choices we expect to confirm overall functionality? Like if we make OCGT super cheap, we expect all investments to be in OCGT. I think this is great, but I guess this will require some sort of additional logic on the results unless we just do visual inspections?