pypsa-eur icon indicating copy to clipboard operation
pypsa-eur copied to clipboard

Wave and floating solar updates

Open lmezilis opened this issue 1 month ago • 5 comments

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • [x] I tested my contribution locally and it works as intended.
  • [x] Code and workflow changes are sufficiently documented.
  • [x] Changed dependencies are added to envs/environment.yaml.
  • [ ] Changes in configuration options are added in config/config.default.yaml.
  • [ ] Changes in configuration options are documented in doc/configtables/*.csv.
  • [ ] Sources of newly added data are documented in doc/data_sources.rst.
  • [ ] A release note doc/release_notes.rst is added.

lmezilis avatar Nov 05 '25 11:11 lmezilis

Changes in configuration options are added in config/config.electricity.yaml.

lmezilis avatar Nov 05 '25 11:11 lmezilis

Great, could you try and resolve the merge conflicts so that we can have a look? Generally, keeping the diff as small as possible will help us review.

fneum avatar Nov 05 '25 12:11 fneum

Can you let me know if the conflicts are resolved? Apologies for delays, but I am a bit new to github and its procedures.

lmezilis avatar Nov 07 '25 10:11 lmezilis

@lmezilis They are, but you need to resolve the pre-commit checks now. See the failed check above or run it locally as described in the docs: https://pypsa-eur.readthedocs.io/en/latest/contributing.html

lkstrp avatar Nov 07 '25 13:11 lkstrp

@lkstrp Ok, I think I completed that, please let me know if I missed anything.

lmezilis avatar Nov 10 '25 14:11 lmezilis