Keep existing conventional generation in sector network
Closes # (if applicable).
Changes proposed in this Pull Request
The sector coupled network currently removes existing conventional generators. This PR adds them back (in the traditional sectoral setup with EU Generators + Links)
Checklist
- [x] I tested my contribution locally and it works as intended.
- [x] Code and workflow changes are sufficiently documented.
- [x] Changed dependencies are added to
envs/environment.yaml. - [x] Changes in configuration options are added in
config/config.default.yaml. - [x] Changes in configuration options are documented in
doc/configtables/*.csv. - [x] Sources of newly added data are documented in
doc/data_sources.rst. - [x] A release note
doc/release_notes.rstis added.
Validator Report
I am the Validator. Download all artifacts here. I'll be back and edit this comment for each new commit.
General
Plots comparison
| Main branch | Feature branch |
|---|---|
Files comparison
| Status | NRMSE | MAE (norm) | |
|---|---|---|---|
| weighted_prices.csv | :warning:Changed | 0.514 | 0.50 |
| price_statistics.csv | :warning:Changed | 0.001 | 0.21 |
| metrics.csv | :warning:Changed | 0.000 | 0.06 |
| nodal_cfs.csv | :warning: NaN mismatch | ||
| nodal_supply_energy.csv | :warning: NaN mismatch | ||
| nodal_capacities.csv | :warning: NaN mismatch | ||
| prices.csv | :warning: NaN mismatch | ||
| supply.csv | :warning: NaN mismatch | ||
| nodal_costs.csv | :warning: NaN mismatch | ||
| market_values.csv | :warning: NaN mismatch | ||
| capacities.csv | :warning: NaN mismatch | ||
| curtailment.csv | :warning: NaN mismatch | ||
| costs.csv | :warning: NaN mismatch | ||
| cfs.csv | :warning: NaN mismatch | ||
| supply_energy.csv | :warning: NaN mismatch | ||
| energy.csv | :warning: NaN mismatch |
NRMSE: Normalized (combined-min-max) Root Mean Square Error MAE (norm): Mean Absolute Error on normalized data (min-max) Status Threshold: MAE (norm) > 0.05 and NRMSE > 0.3
Model Metrics
Benchmarks
Comparing keep_conventionals_in_sector (37c6093) with master (52b8179).
Branch is 8 commits ahead and 0 commits behind.
Last updated on 2024-11-05 11:03:42 CET.
Except for typos (my specialty), there seems to be only the same bug as in master, which is why Windows OS is failing (nut sure about why).
Remaining discussion points could be:
- I designed the same setup for nuclear as for fossil generation (Generator
uraniumconnected with anuclearlink). I think that makes more sense, currently it simply remained a "nuclear generator", but this was a bit confusing - Currently, if existing capacities are kept and the carrier is expandable, only the existing locations can be expanded. The same carrier can not be expanded at a different site, if that site has no existing capacity. Could be potentially fixed, but wasn't needed in our case
Otherwise, seems to work.
Nuclear / coal generation in power only model:
Nuclear/coal generation at sectoral model:
Sectoral model dispatch (in links_t.p1) (Co2L0.5 for whole EU, 121H, 59 clusters)
nuclear
coal
default config settings don't change the current default output (except that nuclear is not kept anymore in the generators)
@martacki What's the status here? Would you like to continue with this, or shall we close it for now?