setuptools-rust icon indicating copy to clipboard operation
setuptools-rust copied to clipboard

2.0 wishlist

Open davidhewitt opened this issue 3 years ago • 3 comments

Just some tidy-ups I'd like to do whenever we get around to a next breaking release:

  • Change Optional[Sequence[str]] arguments to RustExtension to just be Sequence[str] = ().
  • Remove deprecated options to RustExtension.
  • Remove Binding.Exec (just use RustBin).
  • Require all arguments to RustExtension except for target to be passed as keywords (i.e. after * separator).
  • Remove build_rust subcommand (the setup.py entry point is deprecated, so no need to support it IMO)
  • Remove version.py (just set the corresponding values in __init__.py)

davidhewitt avatar Jul 02 '22 20:07 davidhewitt

  • Remove build_rust subcommand (the setup.py entry point is deprecated, so no need to support it IMO)

I would recommend holding off on this as it's not currently possible to migrate setuptools setup.py package build infrastructure to pep517 package build infrastructure due to setuptools pep517 support effectively requiring setup.py build infrastructure itself for bootstrapping.

Currently setup.py builds are still supported in the latest setuptools release, IMO we should probably support them here until we start requiring a version of setuptools that no longer supports setup.py style builds.

jameshilliard avatar Oct 03 '22 20:10 jameshilliard

Thanks for the heads up! I'm in no rush to push forward with a 2.0 release, so potentially we can just wait for upstream before we consider a 2.0 in that case.

davidhewitt avatar Oct 04 '22 06:10 davidhewitt