rust-numpy icon indicating copy to clipboard operation
rust-numpy copied to clipboard

Remove extraction from Vec for PyArrayLikeDyn

Open jakemoran opened this issue 6 months ago • 3 comments

Resolves #491

There seems to be a minor breaking change with this fix where some conversions to PyArrayLikeDyn may now require AllowTypeChange where it wasn't needed previously (which can be seen in the modified test). It seems like this is the correct behavior to me, since the element type is changing, and this makes the behavior in line with conversions from dynamic arrays of higher dimensionality. Still breaking so I'm open to discussion on whether this is the right call or not.

I added one extra test that reproduces the issue from #491 and now passes.

jakemoran avatar May 31 '25 20:05 jakemoran

Thanks for the PR, sorry for the slow review. CI looks to be falling, though I wonder if it's not actually related... 🤔

@ngoldbaum do I recall something about numpy removing support for Windows x86? Did that happen?

davidhewitt avatar Jun 14 '25 22:06 davidhewitt

Nope, and upstream CPython isn't planning to either.

ngoldbaum avatar Jun 15 '25 00:06 ngoldbaum

Flipped PR to rerun CI with no-fail-fast option 🤔

davidhewitt avatar Jul 26 '25 19:07 davidhewitt