rust-numpy icon indicating copy to clipboard operation
rust-numpy copied to clipboard

Support for PyO3 0.23

Open ngoldbaum opened this issue 1 year ago • 1 comments

I'm looking at using rust-numpy with the free-threaded Python build and it looks like the first blocker is 0.23 support. The error I hit out of the box after pointing the cargo.toml at my local copy of PyO3 is:

error: failed to select a version for `pyo3`.
    ... required by package `numpy v0.21.0 (/Users/goldbaum/Documents/rust-numpy)`
versions that meet the requirements `*` are: 0.23.0-dev

the package `numpy` depends on `pyo3`, with features: `gil-refs` but `pyo3` does not have these features.

So it looks like the first step is removing the uses of the gil-refs feature and fully transitioning to the bound reference API.

ngoldbaum avatar Oct 09 '24 09:10 ngoldbaum

Yep, looks like @Icxolu has made great progress in #457 (🙏). We wouldn't merge that until we actually release 0.23 upstream, however.

davidhewitt avatar Oct 10 '24 05:10 davidhewitt

Now that #457 has been merged, would we be able to get an 0.23 release of numpy?

kylebarron avatar Nov 26 '24 05:11 kylebarron

I hope to prep a release branch tonight :)

davidhewitt avatar Nov 26 '24 09:11 davidhewitt

#473 is in the oven :)

davidhewitt avatar Nov 26 '24 22:11 davidhewitt

0.23 was shipped last week 🚀

davidhewitt avatar Dec 03 '24 09:12 davidhewitt