rust-numpy icon indicating copy to clipboard operation
rust-numpy copied to clipboard

Support ndarray 0.16

Open magnusuMET opened this issue 1 year ago • 5 comments

Fixes #438

magnusuMET avatar Aug 12 '24 08:08 magnusuMET

This PR is blocked on https://github.com/rust-ndarray/ndarray-linalg/pull/379

magnusuMET avatar Aug 15 '24 07:08 magnusuMET

Previous discussion about ndarray 0.16, rust-numpy and ndarray-linalg: https://github.com/rust-ndarray/ndarray/discussions/1374

bluss avatar Aug 20 '24 10:08 bluss

Ok, that comment was maybe not super helpful - ndarray 0.16 got a few more changes since that happened. But I think it points out that ndarray-linalg doesn't need to be a strict blocker for this update.

bluss avatar Aug 20 '24 17:08 bluss

I see the main argument: Allow the deprecation and let the end user deal with the dependency through their lockfile. I am not sure how to create a lockfile with the right dependency through cargo invocations, but checking in the lockfile should hopefully work

magnusuMET avatar Aug 21 '24 07:08 magnusuMET

Some more deprecated methods were removed in ndarray post adamreichold's test. I would suggest maybe restricting to ndarray 0.15 and 0.16 if possible (this is not my project -- just how I would do it); I don't usually work with open ranges of dependencies so don't really know.

Hoping ndarray-linalg can be tested using ndarray 0.15 only suggested. With that said, we should be able to get a solution (to update) ndarray-linalg sooner or later..

bluss avatar Aug 21 '24 16:08 bluss

ndarray 0.15 has an MSRV of 1.49, so I think we can limit to 0.15 and 0.16 here. (We are about to move to MSRV 1.63 as per #449.)

davidhewitt avatar Oct 04 '24 08:10 davidhewitt

What’s the status of this PR now?

juntyr avatar Oct 04 '24 08:10 juntyr

Just needs someone to pick up and finish off as per my above comment - the MSRV bump is now applied on main.

davidhewitt avatar Oct 04 '24 10:10 davidhewitt

@davidhewitt Bumped lower ndarray version in a new commit

magnusuMET avatar Oct 04 '24 11:10 magnusuMET

@davidhewitt Let's try again, including the changes in #451

magnusuMET avatar Oct 04 '24 12:10 magnusuMET

thanks everyone for working on this :100:

bluss avatar Oct 04 '24 15:10 bluss