rust-numpy icon indicating copy to clipboard operation
rust-numpy copied to clipboard

Update pyo3 to 0.22.0

Open bschoenmaeckers opened this issue 1 year ago • 3 comments

This is the first iteration of the process to update to pyo3 0.22. The first step is to make the current code compile against the new version. In following MR we should feature gate the deprecated gil-refs api's used and implement every method against the Bound wrapper.

bschoenmaeckers avatar Jun 27 '24 09:06 bschoenmaeckers

I've moved all code using the gil-refs api behind the gil-refs feature so it compiles without it as well now. Please review

bschoenmaeckers avatar Jun 27 '24 14:06 bschoenmaeckers

I'm not sure about the py-clone feature, should it be enabled or is there a better way?

bschoenmaeckers avatar Jun 27 '24 14:06 bschoenmaeckers

I am eager to upgrade to PyO3 0.22 but can't until numpy supports it, so let me know if there are any tasks I can take on to help move this forward! Thanks for getting it started :)

JRRudy1 avatar Jul 01 '24 19:07 JRRudy1

Closing in fever of #435

bschoenmaeckers avatar Jul 23 '24 01:07 bschoenmaeckers