Move guide CI job from netlify to GH actions
At the moment we use netlify build environment to create the guide. I think it's harder to see issues and has differences from the rest of our CI infrastructure based on GitHub actions.
It would be a good cleanup / simplification to remove the netlify build and expand the existing guide-build job to deploy to netlify.
Happy to look at this, also see if we can solve this issue #4855
Right now it seem the guide is already built here: https://github.com/Cheukting/pyo3/blob/3ae3a6ba658953112a45a01c8a54fe1d7dff481c/.github/workflows/gh-pages.yml#L19
All versions will be collected in the gh-pages branch
If I understand correctly, we would like to run this script on GH action then deploy to Netlify
Yes, that sounds correct. We might want to rework the script to be part of noxfile.py, I think at the time I had issues with the netlify build environment which forced me to use bash.
I wonder why the docs and guide are build here: https://github.com/PyO3/pyo3/blob/b4d5935d3fefa908cc8569627bb1ee18ed3d6d60/.netlify/build.sh#L74
Im think the pages on gh-pages are all that is needed as it is built here: https://github.com/PyO3/pyo3/blob/b4d5935d3fefa908cc8569627bb1ee18ed3d6d60/.github/workflows/gh-pages.yml#L49
Let's move the Netify build script to GH action for now and change gh-pages build to only on release
Implemented in #5153