pyo3 icon indicating copy to clipboard operation
pyo3 copied to clipboard

Move guide CI job from netlify to GH actions

Open davidhewitt opened this issue 8 months ago • 6 comments

At the moment we use netlify build environment to create the guide. I think it's harder to see issues and has differences from the rest of our CI infrastructure based on GitHub actions.

It would be a good cleanup / simplification to remove the netlify build and expand the existing guide-build job to deploy to netlify.

davidhewitt avatar Apr 21 '25 09:04 davidhewitt

Happy to look at this, also see if we can solve this issue #4855

Cheukting avatar Apr 22 '25 12:04 Cheukting

Right now it seem the guide is already built here: https://github.com/Cheukting/pyo3/blob/3ae3a6ba658953112a45a01c8a54fe1d7dff481c/.github/workflows/gh-pages.yml#L19

All versions will be collected in the gh-pages branch

Cheukting avatar Apr 22 '25 12:04 Cheukting

If I understand correctly, we would like to run this script on GH action then deploy to Netlify

Cheukting avatar Apr 22 '25 13:04 Cheukting

Yes, that sounds correct. We might want to rework the script to be part of noxfile.py, I think at the time I had issues with the netlify build environment which forced me to use bash.

davidhewitt avatar Apr 25 '25 07:04 davidhewitt

I wonder why the docs and guide are build here: https://github.com/PyO3/pyo3/blob/b4d5935d3fefa908cc8569627bb1ee18ed3d6d60/.netlify/build.sh#L74

Im think the pages on gh-pages are all that is needed as it is built here: https://github.com/PyO3/pyo3/blob/b4d5935d3fefa908cc8569627bb1ee18ed3d6d60/.github/workflows/gh-pages.yml#L49

Cheukting avatar May 18 '25 15:05 Cheukting

Let's move the Netify build script to GH action for now and change gh-pages build to only on release

Cheukting avatar May 19 '25 12:05 Cheukting

Implemented in #5153

Icxolu avatar Jul 05 '25 21:07 Icxolu