pyo3 fixes #4285 -- allow full-path to pymodule with nested declarative modules

Jun 26 '24 04:06 alex

Hmm, how would expanding the macros eagerly work? Handling the variety of different forms a user can write this in is... expansive. (A user can use pyo3::prelude as foo; which this PR obviously doesn't handle.)

Jun 26 '24 11:06 alex

Are there other pieces you'd like here besides expanding to pyfunction/pyclass?

Jul 02 '24 12:07 alex

I think that's just it, I see you solved the Path complication above 👍

The eager expansion / unlimited forms of use imports can be problems for the future.

Jul 02 '24 13:07 davidhewitt

Will add support for those after work today. Thanks for the review

On Tue, Jul 2, 2024, 9:15 AM David Hewitt @.***> wrote:

I think that's just it, I see you solved the Path complication above 👍

The eager expansion / unlimited forms of use imports can be problems for the future.

— Reply to this email directly, view it on GitHub https://github.com/PyO3/pyo3/pull/4288#issuecomment-2203129364, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAAGBGKNVKA5AIDT53ZPC3ZKKRWPAVCNFSM6AAAAABJ5BGK2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTGEZDSMZWGQ . You are receiving this because you authored the thread.Message ID: @.***>

Jul 02 '24 13:07 alex

Ok, added!

Jul 02 '24 21:07 alex