pyo3 icon indicating copy to clipboard operation
pyo3 copied to clipboard

Published 20 hours ago • verified publisher icon PyO3

remove internal APIs from pyo3-ffi

Open Cheukting opened this issue 1 year ago • 2 comments

Using methods from PyAny to replace calling _Py internal APIS from pyo3-ffi.

see #3762

Cheukting avatar May 22 '24 00:05 Cheukting

Looks like CI is failing due to a warning from an unused macro.

alex avatar May 22 '24 00:05 alex

Sure, this PR is still WIP. I will work on it more soon.

Cheukting avatar May 22 '24 18:05 Cheukting

@davidhewitt happy to do it either here or open a new PR for the suggestion

Cheukting avatar May 24 '24 15:05 Cheukting

Given this PR is still relatively self-contained, I'd be happy for the additional changes to be pushed here 👍

davidhewitt avatar May 24 '24 15:05 davidhewitt

@Cheukting Could you have a look into the build error on GraalPy from our CI? If you'd like, we can also label this PR so the cull CI suite is run on every push so you do not have to wait for the merge queue to validate your changes?

adamreichold avatar Jun 02 '24 09:06 adamreichold

@adamreichold it is due to an unused import it seems: https://github.com/PyO3/pyo3/actions/runs/9336538447/job/25697227447#step:10:132

I will have a look into it, thanks!

Cheukting avatar Jun 05 '24 07:06 Cheukting

@adamreichold do you mind running the check on the merge queue again to see if my fix works?

Cheukting avatar Jun 05 '24 09:06 Cheukting