pyo3 icon indicating copy to clipboard operation
pyo3 copied to clipboard

Add support for mappingproxy objects

Open dignissimus opened this issue 2 years ago • 4 comments

This pull request adds support for mappingproxy objects.

Resolves #2108

dignissimus avatar Jun 05 '22 14:06 dignissimus

Hi @dignissimus, just wondering what the status of this is and whether you're waiting for any input from me? No rush at all, just browsing our backlog of PRs.

davidhewitt avatar Jul 07 '22 07:07 davidhewitt

Hi @dignissimus, just wondering what the status of this is and whether you're waiting for any input from me? No rush at all, just browsing our backlog of PRs.

Hey! For the elements parameter, I'm looking for input on the type? When writing it, I saw the benefit of impl IntoPyDict as the fact that it covered types of data, so they don't have to be converted. to other datatypes. But if something else works better, I'd be willing to change it.

dignissimus avatar Jul 07 '22 21:07 dignissimus

Also, some of the builds fail (emscripten) for reasons outside of testing, if I remember correctly it might be to do with imports? I'm not able to fix it on my own without help. I'd need guidance to amend it or have somebody else add a commit to the PR.

dignissimus avatar Jul 07 '22 21:07 dignissimus

Cool - added a bunch of suggestions which should help you continue moving!

Thanks! I'll make the changes this Saturday

dignissimus avatar Jul 08 '22 00:07 dignissimus

Hello @dignissimus

Thank you for contributing to PyO3!

The project is undergoing changes on its licensing model to better align with the rest of the Rust crates ecosystem.

Before your work gets merged, please express your consent by leaving a comment on this pull request.

Thank you!

DataTriny avatar Apr 16 '23 09:04 DataTriny

Has there been any update on this?

ofek avatar Jul 26 '23 16:07 ofek

No progress since what is seen here, it's also not a priority feature for me so unlikely to move any time soon without further external contributions.

davidhewitt avatar Jul 26 '23 20:07 davidhewitt

Superseded by #3521

davidhewitt avatar Nov 26 '23 09:11 davidhewitt