maturin-action icon indicating copy to clipboard operation
maturin-action copied to clipboard

Can we update `rust-cross/rust-musl-cross` to ` rust-cross/manylinux-cross`?

Open patrick91 opened this issue 2 months ago • 4 comments

I was trying to get a wheel for Python 3.14 and musllinux for a package of mine and I noticed that the image used for building on musllinux is rust-cross/rust-musl-cross, while for standard Linux the image used is ghcr.io/rust-cross/manylinux2014-cross:ARCH

I was taking a look at the repo for that image and it seems like there's support for musllinux: https://github.com/rust-cross/manylinux-cross/tree/main/musllinux_1_2 and the images seem to use the musl-cross image as a base: https://github.com/rust-cross/manylinux-cross/blob/main/musllinux_1_2/aarch64/Dockerfile#L3

Is there a reason why we are using rust-cross/rust-musl-cross? If not, I'd be happy to contribute a PR to update the references

patrick91 avatar Oct 29 '25 12:10 patrick91

Is there a reason why we are using rust-cross/rust-musl-cross?

For most projects maturin only needs a musl gcc so rust-musl-cross images are good enough for most users, no need to pull in big musllinux_1_2 images with different versions of python installed.

messense avatar Oct 29 '25 13:10 messense

@messense so is my action set up wrongly (or in a non-optimal way)?

https://github.com/patrick91/rignore/blob/main/.github/workflows/CI.yml#L53-L90

patrick91 avatar Oct 29 '25 14:10 patrick91

You can get rid of the before-script-linux I think.

messense avatar Oct 30 '25 07:10 messense

@messense but then I'd miss the latest version of python (that's why I was suggesting to use the rust-cross/manylinux-cross image, like it's done for the others https://github.com/PyO3/maturin-action/blob/main/src/index.ts#L59-L64)

patrick91 avatar Oct 30 '25 11:10 patrick91