pyfpga icon indicating copy to clipboard operation
pyfpga copied to clipboard

Verify windows support

Open rodrigomelo9 opened this issue 4 years ago • 6 comments

rodrigomelo9 avatar Feb 11 '21 01:02 rodrigomelo9

I found a problem on windows. So I made a pull-request https://github.com/PyFPGA/pyfpga/pull/19#issue-576159749

motty-mio2 avatar Feb 19 '21 04:02 motty-mio2

Hi @motty-mio2 again thanks (merged, whit a modification to only be applied in Tcl files). It was the only change that you needed? PyFPGA works for you in Windows with Vivado?

Regards, Rodrigo

rodrigomelo9 avatar Feb 19 '21 21:02 rodrigomelo9

Thank you for this merge. With this change, I can generate bitstream file for FPGA in Windows with Vivado. Thanks.

motty-mio2 avatar Feb 20 '21 01:02 motty-mio2

Great to know :-D

I could probably add a CI action to check the python part on windows, also the openflow solution (based on FOSS and solved from a bash script), but I can't check the vendor tools there. I need to add some kind of Tcl verification (such as to check the file separators).

Again, thanks to you.

rodrigomelo9 avatar Feb 20 '21 01:02 rodrigomelo9

Tested PR #43 by Markus on Windows (commit 65b43b8) and it seems to work when pytest is ran in pyfpga/tests. Running pytest tests in project root does not seem to work as pytest ignores the tests directory. Might be helpful to fix in the readme.

gts-bzi avatar Aug 05 '24 12:08 gts-bzi

Fixed (you can run pytest also from project root now).

rodrigomelo9 avatar Aug 06 '24 01:08 rodrigomelo9

Fixed on dev

rodrigomelo9 avatar Sep 07 '24 17:09 rodrigomelo9